Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CloudFormation on ECS example #78

Merged
merged 5 commits into from
May 1, 2023
Merged

Conversation

jonmchan
Copy link
Contributor

@jonmchan jonmchan commented Apr 6, 2023

Closes #24

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

examples/cloudformation/cloudformation.yml Show resolved Hide resolved
examples/cloudformation/cloudformation.yml Show resolved Hide resolved
@jonmchan jonmchan requested a review from max-lobur April 6, 2023 20:40
@max-lobur max-lobur changed the title adding cloud formation example Adding CloudFormation on ECS example Apr 7, 2023
@max-lobur
Copy link
Contributor

I need to test this in AWS before merge

jonmchan and others added 2 commits April 27, 2023 11:58
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
@jonmchan
Copy link
Contributor Author

jonmchan commented Apr 27, 2023

I would argue that we commit the documentation as is letting people know that this is just an example and we don't maintain these examples. I don't think it would be any more out of date than https://github.com/cloudposse/bastion/tree/main/examples/compose. The docker-compose file in there is still set to version 2! I would be surprised if https://github.com/cloudposse/bastion/tree/main/examples/compose still works straight out of the box.

@max-lobur max-lobur requested review from a team as code owners May 1, 2023 16:28
@max-lobur
Copy link
Contributor

Validated with https://www.cloudformation-validator.com/

@max-lobur
Copy link
Contributor

I would argue that we commit the documentation as is letting people know that this is just an example and we don't maintain these examples. I don't think it would be any more out of date than https://github.com/cloudposse/bastion/tree/main/examples/compose. The docker-compose file in there is still set to version 2! I would be surprised if https://github.com/cloudposse/bastion/tree/main/examples/compose still works straight out of the box.

Agreed

@jonmchan jonmchan merged commit 622f819 into main May 1, 2023
@jonmchan jonmchan deleted the cloudformation-example branch May 1, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for AWS ECS
3 participants