-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CloudFormation on ECS example #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgecrew has found errors in this PR ⬇️
I need to test this in AWS before merge |
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
I would argue that we commit the documentation as is letting people know that this is just an example and we don't maintain these examples. I don't think it would be any more out of date than https://github.com/cloudposse/bastion/tree/main/examples/compose. The docker-compose file in there is still set to version 2! I would be surprised if https://github.com/cloudposse/bastion/tree/main/examples/compose still works straight out of the box. |
Validated with https://www.cloudformation-validator.com/ ✅ |
Agreed |
Closes #24