Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Additional Readme Sections #74

Merged
merged 10 commits into from
Jul 6, 2018
Merged

Add Additional Readme Sections #74

merged 10 commits into from
Jul 6, 2018

Conversation

osterman
Copy link
Member

@osterman osterman commented Jul 6, 2018 •
edited
Loading

what

  • Add support for screenshots
  • Add support for multiple copyright holders
  • Add support for references

why

  • Screenshots make projects a lot more appealing
  • Some projects have multiple copyright holders
  • We should add references for additional context

references

@osterman osterman added the wip Work in Progress: Not ready for final review or merge label Jul 6, 2018
@osterman osterman removed the wip Work in Progress: Not ready for final review or merge label Jul 6, 2018
@osterman osterman changed the title Add demo screenshot Add Additional Readme Sections Jul 6, 2018
@osterman osterman mentioned this pull request Jul 6, 2018
Merged
sarkis
sarkis approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@sarkis sarkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just assuming the demo.svg will look right as it is pointing to master as the source and it doesn't exist until this is merged.

@osterman
Copy link
Member Author

osterman commented Jul 6, 2018

Yea, fingers crossed demo.svg works after we merge to master. It worked on a test branch, but the CDN might have cached the 404.

@osterman osterman merged commit 6526365 into master Jul 6, 2018
@osterman osterman deleted the add-readme-sections branch July 6, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarkis sarkis sarkis approved these changes

@vadim-hleif vadim-hleif Awaiting requested review from vadim-hleif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @sarkis