Skip to content

0.4.2
Compare
Choose a tag to compare
@aknysh aknysh released this 15 Mar 03:21
· 221 commits to master since this release
0.4.2
636215c
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

what

  • Provide all .go files at once to go vet
  • Remove -d flag from go get
  • Install golint

why

  • If .go files provided sequentially to go vet, it couldn't find dependencies throwing the error:
make[1]: Entering directory `/home/travis/gopath/src/github.com/cloudposse/slack-notifier'
find . ! -path "*/vendor/*" ! -path "*/.glide/*" -type f -name '*.go' | xargs -n 1 /home/travis/.gimme/versions/go1.9.4.linux.amd64/bin/go vet -v
Checking file slack_notifier.go
main.go:45:24: undeclared name: Field
  • go get installs packages automatically (if -d flag is not specified)
  • golint was just downloaded, but not installed
find . ! -path "*/vendor/*" ! -path "*/.glide/*" -type f -name '*.go' | xargs -n 1 golint
xargs: golint: No such file or directory

references

Assets 2
Loading