Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teleport] Upgrade Teleport to 3.2.4 #458

Merged
merged 3 commits into from
Apr 26, 2019
Merged

[teleport] Upgrade Teleport to 3.2.4 #458

merged 3 commits into from
Apr 26, 2019

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 26, 2019 •
edited
Loading

what

  • Upgrade Teleport to 3.2.4
  • When syncing clocks, show results of sync

why

  • Get support from TELEPORT_SITE and TELEPORT_AUTH environment variables.
  • Previous version gave no feedback on successful sync of clock, giving impression that clocks were still out of sync

reference

gravitational/teleport#2675

@Nuru Nuru requested review from aknysh, goruha and osterman April 26, 2019 16:20
@aknysh
Copy link
Member

aknysh commented Apr 26, 2019

The changed files don't reflect the PR description

aknysh
aknysh reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

osterman
osterman previously requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description to match changes. Not sure why the hwclock stuff is changing.

@Nuru Nuru dismissed osterman’s stale review April 26, 2019 16:59

Made requested changes

@Nuru Nuru merged commit f61b069 into master Apr 26, 2019
@goruha goruha deleted the quickfix branch April 26, 2019 17:22
leb4r pushed a commit that referenced this pull request Jan 25, 2022
@cloudpossebot @osterman
Update kubectl-1.16 to 1.18.10 (#458)
a9d705d 
Co-authored-by: osterman <osterman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh left review comments

@goruha goruha goruha approved these changes

@osterman osterman osterman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nuru @aknysh @osterman @goruha