Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output file handling for components that contain slashes #14

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Fix output file handling for components that contain slashes #14

merged 4 commits into from
Sep 15, 2023

Conversation

osterman
Copy link
Member

@osterman osterman commented Sep 14, 2023 •
edited
Loading

what

  • Slash slashes in the path

why

  • Components may contain slashes (e.g. eks/cluster), which will cause redirection to the $OUTPUT_FILE to fail if the directory does not exist.

CleanShot 2023-09-14 at 15 30 57

milldr
milldr previously approved these changes Sep 14, 2023
View reviewed changes
@osterman osterman added the patch A minor, backward compatible change label Sep 14, 2023
@osterman osterman merged commit 4c121e3 into main Sep 15, 2023
@osterman osterman deleted the fix-output-file-handling branch September 15, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @milldr