Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add process-templates input #58

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Aug 21, 2024

what

  • Add process-templates input as the value of the --process-templates flag to pass to atmos describe component.
  • Add appropriate test cases.

why

  • Some template functions such as atmos.Component require authentication to remote backends. We should allow disabling this.

references

> Run cloudposse/github-action-atmos-get-setting@v1
template: all-atmos-sections:163:26: executing "all-atmos-sections" at <atmos.Component>: error calling Component: exit status 1

Error: error configuring S3 Backend: IAM Role (arn:aws:iam::xxxxxxxxxxxx:role/xxxx-core-gbl-root-tfstate) cannot be assumed.

There are a number of possible causes of this - the most common are:
  * The credentials used in order to assume the role are invalid
  * The credentials do not have appropriate permission to assume the role
  * The role ARN is not valid

Error: NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors

I've kept the default value of process-templates as true in order to ensure backwards compatibility.

@korenyoni korenyoni added the bug 🐛 An issue with the system label Aug 21, 2024
korenyoni added a commit to cloudposse/github-action-atmos-terraform-plan that referenced this pull request Aug 21, 2024
@korenyoni korenyoni changed the title fix: do not process templates feature: add process-templates input Aug 23, 2024
@korenyoni korenyoni added the enhancement New feature or request label Aug 23, 2024
goruha
goruha previously approved these changes Aug 23, 2024
goruha
goruha previously approved these changes Aug 27, 2024
@korenyoni korenyoni requested a review from goruha August 27, 2024 18:27
@korenyoni korenyoni requested a review from osterman August 28, 2024 14:54
@korenyoni korenyoni added the minor New features that do not break anything label Aug 28, 2024
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. I made a few comments that should probably be addressed before we merge.

@korenyoni korenyoni requested a review from mcalhoun August 28, 2024 15:56
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korenyoni korenyoni merged commit f74ff54 into main Aug 28, 2024
12 checks passed
@korenyoni korenyoni deleted the fix/process-templates-flag branch August 28, 2024 16:01
Copy link

These changes were released in v1.3.0.

korenyoni added a commit that referenced this pull request Aug 28, 2024
@korenyoni korenyoni restored the fix/process-templates-flag branch August 28, 2024 17:44
korenyoni added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system enhancement New feature or request minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants