generated from cloudposse-github-actions/composite-template
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add process-templates
input
#58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
added a commit
to cloudposse/github-action-atmos-terraform-plan
that referenced
this pull request
Aug 21, 2024
process-templates
input
goruha
previously approved these changes
Aug 23, 2024
goruha
previously approved these changes
Aug 27, 2024
osterman
reviewed
Aug 28, 2024
mcalhoun
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good. I made a few comments that should probably be addressed before we merge.
mcalhoun
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These changes were released in v1.3.0. |
korenyoni
added a commit
that referenced
this pull request
Aug 28, 2024
This reverts commit f74ff54.
korenyoni
added a commit
that referenced
this pull request
Aug 28, 2024
This reverts commit f74ff54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
🐛 An issue with the system
enhancement
New feature or request
minor
New features that do not break anything
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
process-templates
input as the value of the--process-templates
flag to pass toatmos describe component
.why
atmos.Component
require authentication to remote backends. We should allow disabling this.references
I've kept the default value of
process-templates
astrue
in order to ensure backwards compatibility.