Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stage arn output #12

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Add stage arn output #12

merged 2 commits into from
Feb 3, 2022

Conversation

mwakaba2
Copy link
Contributor

@mwakaba2 mwakaba2 commented Feb 3, 2022

what

  • Added gateway's stage arn to output.
  • Updated readme to include the new output.

why

  • The stage arn is needed when defining associations between API gateway stage and a WAF, specifically in the WAF's association resource arns list in cloudposse/terraform-aws-waf module.

@mwakaba2 mwakaba2 requested review from a team as code owners February 3, 2022 22:15
@Gowiem
Copy link
Member

Gowiem commented Feb 3, 2022

/test all

@Gowiem Gowiem merged commit ba40fc9 into cloudposse:main Feb 3, 2022
@mwakaba2 mwakaba2 deleted the add-stage-arn-as-output branch February 4, 2022 13:55
@mwakaba2
Copy link
Contributor Author

mwakaba2 commented Feb 4, 2022

@Gowiem thank you for reviewing this quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwakaba2 @Gowiem @cloudpossebot