Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow slash in log group names #26

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 18, 2021

what

  • Custom label for cloudwatch log group name

why

  • Allow slash in log group names

references

test

provider "aws" {
  region = "us-east-2"
}

module "cloudwatch_logs" {
  source = "github.com/cloudposse/terraform-aws-cloudwatch-logs?ref=allow-slash-log-group-names"

  name = "/aws/kinesisfirehose/aws-waf-logs-dev-app"
}

results in

  # module.cloudwatch_logs.aws_cloudwatch_log_group.default[0] will be created
  + resource "aws_cloudwatch_log_group" "default" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + name              = "/aws/kinesisfirehose/aws-waf-logs-dev-app"
      + retention_in_days = 30
      + tags              = {
          + "Name" = "/aws/kinesisfirehose/aws-waf-logs-dev-app"
        }
      + tags_all          = {
          + "Name" = "/aws/kinesisfirehose/aws-waf-logs-dev-app"
        }
    }

@nitrocode nitrocode marked this pull request as ready for review November 18, 2021 18:47
@nitrocode nitrocode requested review from a team as code owners November 18, 2021 18:47
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Nov 18, 2021
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 020e078 into master Nov 18, 2021
@nitrocode nitrocode deleted the allow-slash-log-group-names branch November 18, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants