Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve external-dns snippet in readme #986

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

sgtoj
Copy link
Contributor

@sgtoj sgtoj commented Feb 21, 2024

what

  • update the eks/external-dns component example in readme
    • set latest chart version
    • set the resource configure properly
    • add txt_prefix var to snippet

why

  • help the future engineers deploying or updating external-dns

references

  • n/a

@sgtoj sgtoj requested review from a team as code owners February 21, 2024 13:26
@goruha goruha added the no-release Do not create a new release (wait for additional code changes) label Oct 1, 2024
@goruha goruha merged commit 2de47e8 into cloudposse:main Oct 1, 2024
4 checks passed
goruha added a commit to cloudposse-terraform-components/aws-eks-external-dns that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants