Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added output cluster_members for resource aws_docdb_cluster #107

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

Faris96Hub
Copy link
Contributor

what

Added the Output "cluster_members" for the resource "aws_docdb_cluster".

why

Needed for monitoring reasons of the DocumentDB Cluster on a Node-level. Needed when creating a CloudWatch alarm on Node-level because the Dimesion of the alarm needs the cluster memebers.

references

https://docs.aws.amazon.com/documentdb/latest/developerguide/cloud_watch.html#:~:text=and%20ReadIOPS.-,Amazon%20DocumentDB%20dimensions,-The%20metrics%20for

@Faris96Hub Faris96Hub requested review from a team as code owners August 20, 2024 18:36
@mergify mergify bot added the triage Needs triage label Aug 20, 2024
outputs.tf Outdated Show resolved Hide resolved
@RoseSecurity
Copy link
Member

/terratest

@RoseSecurity
Copy link
Member

This looks good to me if @kevcube is in favor as well. I believe this module creates one cluster so one() or flatten() is y'all's preference

@kevcube kevcube enabled auto-merge (squash) September 5, 2024 16:53
@kevcube kevcube changed the title fix: added output cluster_members for resource aws_docdb_cluster feat: added output cluster_members for resource aws_docdb_cluster Sep 5, 2024
@kevcube
Copy link
Contributor

kevcube commented Sep 5, 2024

LGTM but @Faris96Hub I updated your PR title to feature instead of fix 😄

kevcube
kevcube previously approved these changes Sep 5, 2024
@mergify mergify bot removed the triage Needs triage label Sep 5, 2024
@kevcube
Copy link
Contributor

kevcube commented Sep 5, 2024

/terratest

@kevcube
Copy link
Contributor

kevcube commented Sep 5, 2024

@RoseSecurity I'm the last committer here for a formatting fix so my approval doesn't count, can you approve?

@kevcube kevcube merged commit 7485923 into cloudposse:main Sep 5, 2024
25 checks passed
@RoseSecurity
Copy link
Member

Thanks for the contribution!

Copy link

github-actions bot commented Sep 5, 2024

These changes were released in v0.26.2.

@schealex
Copy link

@RoseSecurity any reasing for this not being included in 0.27?

image

as far as i can see the 0.26.2 should be the latest version. but tf registry shows 0.27 which does not include these changes

@kevcube
Copy link
Contributor

kevcube commented Sep 16, 2024

@schealex 👀

@kevcube
Copy link
Contributor

kevcube commented Sep 16, 2024

@schealex something got seriously messed up with our semver calculations, but these changes ARE included in the published v0.26.2, (which is published more recently than 0.27.0

so to use them today just reference 0.26.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants