-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added output cluster_members for resource aws_docdb_cluster #107
Conversation
/terratest |
This looks good to me if @kevcube is in favor as well. I believe this module creates one cluster so |
LGTM but @Faris96Hub I updated your PR title to feature instead of fix 😄 |
/terratest |
@RoseSecurity I'm the last committer here for a formatting fix so my approval doesn't count, can you approve? |
Thanks for the contribution! |
These changes were released in v0.26.2. |
@RoseSecurity any reasing for this not being included in 0.27? as far as i can see the 0.26.2 should be the latest version. but tf registry shows 0.27 which does not include these changes |
@schealex something got seriously messed up with our semver calculations, but these changes ARE included in the published so to use them today just reference |
what
Added the Output "cluster_members" for the resource "aws_docdb_cluster".why
Needed for monitoring reasons of the DocumentDB Cluster on a Node-level. Needed when creating a CloudWatch alarm on Node-level because the Dimesion of the alarm needs the cluster memebers.references
https://docs.aws.amazon.com/documentdb/latest/developerguide/cloud_watch.html#:~:text=and%20ReadIOPS.-,Amazon%20DocumentDB%20dimensions,-The%20metrics%20for