Terraform 0.14 upgrade #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
aknysh
approved these changes
Dec 11, 2020
aknysh
previously requested changes
Dec 11, 2020
|
/test all |
1 similar comment
|
/test all |
Nuru
force-pushed
the
terraform-0.14-upgrade
branch
from
aa9a7b5
to
d537054
Compare
|
/test all |
|
/test all |
osterman
reviewed
Dec 11, 2020
| @@ -51,7 +51,9 @@ description: |- | |||
| usage: |- | |||
| ```hcl | |||
| module "dynamodb_autoscaler" { | |||
| source = "git::https://github.com/cloudposse/terraform-aws-dynamodb-autoscaler.git?ref=master" | |||
| source = "cloudposse/dynamodb-autoscaler/aws" | |||
There was a problem hiding this comment.
Our regex should capture the whitespace to preserve the formatting
There was a problem hiding this comment.
With the comment below it, the example is formatted as terraform fmt would format it.
osterman
approved these changes
Dec 11, 2020
sidprak
added a commit
to verkada/terraform-aws-dynamodb-autoscaler
that referenced
this pull request
Apr 28, 2021
* make this module v14 compatible (cloudposse#27) Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com> * Terraform 0.14 upgrade (cloudposse#28) * Fix auto-context and validate-codeowners (cloudposse#29) * Update README.md and docs (cloudposse#30) Co-authored-by: Nuru <Nuru@users.noreply.github.com> * Terraform 0.14 upgrade (cloudposse#31) * Terraform 0.14 upgrade * updated workflows * Updated README.md Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com> * context.tf updated to v0.24.1, minimum required Terraform version bumped to 0.13.0 when needed, readme updated (cloudposse#33) Co-authored-by: Jürgen W <jurgenweber@users.noreply.github.com> Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com> Co-authored-by: Nuru <Nuru@users.noreply.github.com> Co-authored-by: Cloud Posse Bot (CI/CD) <bot@cloudposse.com> Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why