Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS record TTL value transformed to be a variable #7

Merged
merged 4 commits into from
Aug 25, 2017
Merged

DNS record TTL value transformed to be a variable #7

merged 4 commits into from
Aug 25, 2017

Conversation

SweetOps
Copy link
Contributor

@SweetOps SweetOps commented Aug 25, 2017 •
edited by osterman
Loading

What

  • Changed hardcode ttl= "60" to variable

Why

  • Manifests shouldn't hardcode the TTL

@SweetOps SweetOps self-assigned this Aug 25, 2017
@const-bon const-bon changed the title remove hardcoded ttl value DNS TTL value transformed to be a variable Aug 25, 2017
@const-bon const-bon changed the title DNS TTL value transformed to be a variable DNS record TTL value transformed to be a variable Aug 25, 2017
@const-bon const-bon merged commit eb68bbf into master Aug 25, 2017
@const-bon const-bon deleted the ttl_variable branch August 25, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-bon const-bon const-bon approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees

@SweetOps SweetOps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SweetOps @const-bon