Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In main.tf : resource aws_eip replace deprecated vpc argument by domain #109

Closed
wants to merge 2 commits into from

Conversation

RobinMayo
Copy link

what

Remove deprecated argument in resource aws_eip and replace it with the new argument recommended by Hashicorp AWS provider.

why

To remove terraform warning when plan or apply stack and to be up to date.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip

@RobinMayo RobinMayo requested a review from a team as a code owner June 1, 2023 15:35
max-lobur
max-lobur previously approved these changes Jun 1, 2023
Copy link
Contributor

@max-lobur max-lobur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In accordance to:

resource/aws_eip: Deprecate vpc attribute. Use domain instead (hashicorp/terraform-provider-aws#31567)

@max-lobur
Copy link
Contributor

Note that this module has other AWS provider V5 issues: https://github.com/cloudposse/actions/actions/runs/5123264908

I will not be able to merge until I fix those.

@RobinMayo
Copy link
Author

Thanks for your response. To be honest, I wanted to see if this module was still maintained. I am glad to see your reactivity ! I will look for other aws 5.0 issues or deprecation.

Regards

@bsramin
Copy link

bsramin commented Aug 14, 2023

Hello! Any news?

@bsramin
Copy link

bsramin commented Feb 6, 2024

if the project is abandoned, please write it, or if you are looking for some new maintainer...

@hans-d
Copy link

hans-d commented Mar 8, 2024

/terratest

Copy link

mergify bot commented Mar 9, 2024

Thanks @RobinMayo for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
@loganbest
Copy link

Any update here?

Copy link

mergify bot commented May 10, 2024

💥 This pull request now has conflicts. Could you fix it @RobinMayo? 🙏

@mergify mergify bot added the conflict This PR has conflicts label May 10, 2024
Copy link

mergify bot commented May 10, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this May 10, 2024
@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants