-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In main.tf : resource aws_eip replace deprecated vpc argument by domain #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In accordance to:
resource/aws_eip: Deprecate vpc attribute. Use domain instead (hashicorp/terraform-provider-aws#31567)
Note that this module has other AWS provider V5 issues: https://github.com/cloudposse/actions/actions/runs/5123264908 I will not be able to merge until I fix those. |
Thanks for your response. To be honest, I wanted to see if this module was still maintained. I am glad to see your reactivity ! I will look for other aws 5.0 issues or deprecation. Regards |
Hello! Any news? |
if the project is abandoned, please write it, or if you are looking for some new maintainer... |
/terratest |
Thanks @RobinMayo for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
Any update here? |
💥 This pull request now has conflicts. Could you fix it @RobinMayo? 🙏 |
This PR was closed due to inactivity and merge conflicts. 😭 |
what
Remove deprecated argument in resource aws_eip and replace it with the new argument recommended by Hashicorp AWS provider.
why
To remove terraform warning when plan or apply stack and to be up to date.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip