feat: allow passing in a permissions boundary #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Nov 22, 2024
variables.tf
Outdated
|
|
||
| variable "permissions_boundary" { | ||
| type = string | ||
| default = "" |
There was a problem hiding this comment.
Can this default to null instead?
Suggested change
| default = "" | |
| default = null |
nitrocode
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Please regenerate the docs
I believe you can run
make init
# one of the below should work
make docker/readme
make readme
nitrocode
reviewed
Nov 22, 2024
main.tf
Outdated
| @@ -137,6 +137,8 @@ module "cloudwatch_log" { | |||
|
|
|||
| retention_in_days = var.retention_in_days | |||
|
|
|||
| permissions_boundary = var.permissions_boundary | |||
There was a problem hiding this comment.
What do you think of prefixing the inlut with logging_ so it's flear the perm boundary is for the cloudwatch logging module's resources ?
Suggested change
| permissions_boundary = var.permissions_boundary | |
| permissions_boundary = var.logging_permissions_boundary |
nitrocode
reviewed
Nov 22, 2024
variables.tf
Outdated
| @@ -200,3 +200,9 @@ variable "transport_protocol" { | |||
| error_message = "Invalid protocol type must be one of: udp, tcp." | |||
| } | |||
| } | |||
|
|
|||
| variable "permissions_boundary" { | |||
There was a problem hiding this comment.
Related to https://github.com/cloudposse/terraform-aws-ec2-client-vpn/pull/115/files#r1853814788
Suggested change
| variable "permissions_boundary" { | |
| variable "logging_permissions_boundary" { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allows a permissions_boundary to be passed in to this module.
why
The cloudwatch logs module being referenced in this module creates an IAM role. Currently there is no way to set a permissions boundary for this role (which make's it impossible to use this module in an environment that requires permission boundaries). This PR allows a boundary to be set and then passed into the sub module that contains IAM resources.
references