Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support deployment of static assets to CDN #73

Merged
merged 1 commit into from
Mar 17, 2021
Merged

feat: add support deployment of static assets to CDN #73

merged 1 commit into from
Mar 17, 2021

Conversation

jhosteny
Copy link
Contributor

what

  • Update the terraform-aws-codebuild dependency to pick up the secondary artifact changes
  • Expose the secondary artifact configuration settings as variables

why

  • The intent is to wire the secondary artifact configuration up through the terraform-aws-ecs-web-app module to allow for a lightweight static asset deployment through an S3 CDN that is integrated in one build

references

@jhosteny jhosteny requested review from a team as code owners March 17, 2021 21:01
@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit 1f49938 into cloudposse:master Mar 17, 2021
@jhosteny jhosteny deleted the feat/cdn-artifact branch March 17, 2021 21:56
This was referenced Mar 17, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the module to configure secondary artifact sources in codebuild
2 participants
@jhosteny @jamengual