-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update terraform-aws-ecs-codepipeline dependency #52
feat: update terraform-aws-ecs-codepipeline dependency #52
Conversation
/test all |
@jhosteny Mind trying to pass |
Hi @Gowiem - I just added this. I'll keep an eye out for the next status check to see if there are further issues. |
/test all |
@jhosteny Ah sorry, gotta request another change -- Tests failed with:
Can you set the |
/test all |
Hi @Gowiem, I just pushed before your comment. I deleted it, but the default is an empty string. It looks like you just kicked the test off again, so I will wait to investigate if that needs to be explicitly |
@Gowiem this seems to be a different (unrelated to this PR) failure now. I'll be able to dig into it further after the weekend. |
@jhosteny Yeah, that is unrelated to your work I believe. Those might be transient errors... as we've had a number of issues with S3 buckets in the past (though I'm not sure about the ALB issue). I'll fire off the terratests again and we'll see. |
/test terratest |
Huh seems to be recurring... Now I'm wondering if one of the terratest's |
@Gowiem thanks! I'll check back in later this week on it. |
/test terratest |
@osterman @jamengual arrgh. It looks like the GH provider was just tagged at 2.9.0 6 hours ago, and between 2.8.1 and 2.9.0, the anonymous setting was removed. I think the https://github.com/cloudposse/terraform-github-repository-webhooks module will need to be changed yet again to either set the pessimistic constraint operator to |
/test terratest |
/test terratest |
@jhosteny try rebasing... I think @jamengual has fixed tests on this module. |
/test all |
what
github_anonymous
variable from the https://github.com/cloudposse/terraform-aws-ecs-codepipeline/ module through this module as a variablewhy
references