Feature: Namespace and Name List #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
reviewed
Dec 24, 2022
There was a problem hiding this comment.
please add the new variables and add them to the module in the example https://github.com/cloudposse/terraform-aws-eks-iam-role/tree/master/examples/complete
aknysh
reviewed
Dec 24, 2022
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
|
/test all |
1 similar comment
|
/test all |
aknysh
reviewed
Dec 27, 2022
| # Usually there is no need to add both service account methods of attachment. But there is precluding you from doing so. | ||
| # Multiple Service Account attachments | ||
| service_account_namespace_name_list = [ | ||
| "kube-system:autoscaler", |
There was a problem hiding this comment.
since it sets the same name and namespace, it will not collide with
service_account_name = "autoscaler"
service_account_namespace = "kube-system"
?
There was a problem hiding this comment.
it actually would, they are joined via &&
aknysh
reviewed
Dec 27, 2022
aknysh
reviewed
Dec 27, 2022
|
/test all |
|
/test all |
aknysh
reviewed
Dec 27, 2022
| aws_iam_policy_document = [data.aws_iam_policy_document.autoscaler.json] | ||
|
|
||
| context = module.this.context | ||
| } | ||
| data "aws_iam_policy_document" "autoscaler" { |
aknysh
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
*:*