Chore: add missing AMI types #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBtd
force-pushed
the
chore/add_missing_ami_types
branch
from
77cb023 to
0577194
Compare
- Update the `ami_type` variable description with new valid values for the associated Amazon Machine Image (AMI) with the EKS Node Group. Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
QuentinBtd
force-pushed
the
chore/add_missing_ami_types
branch
from
32a1ba5 to
d537de3
Compare
Nuru
added
wontfix
|
@QuentinBtd Thank you for this PR. Unfortunately, it is not as simple as that. See:
I am closing this PR. You may want to consider contributing to #180, or wait until we get around to adding this support (not currently scheduled). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adding missing AMI types
why
AL2023_x86_64_STANDARDandAL2023_ARM_64_STANDARDare available.references
https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html#AmazonEKS-Type-Nodegroup-amiType