Groundwork new workflows #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-lobur
requested review from
jamengual and
joe-niland
and removed request for
a team
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -121,7 +121,7 @@ | |||
| node_type = var.instance_type | |||
| num_cache_clusters = var.cluster_mode_enabled ? null : var.cluster_size | |||
| port = var.port | |||
| parameter_group_name = join("", aws_elasticache_parameter_group.default.*.name) | |||
| parameter_group_name = join("", aws_elasticache_parameter_group.default[*].name) | |||
There was a problem hiding this comment.
Ensure AWS ElastiCache Redis cluster with Multi-AZ Automatic Failover feature set to enabled
Resource: aws_elasticache_replication_group.default | Bridgecrew ID: BC_AWS_GENERAL_185 | Checkov ID: CKV2_AWS_50
How to Fix
resource "aws_elasticache_replication_group" "pass" {
automatic_failover_enabled = true
preferred_cache_cluster_azs = ["us-west-2a", "us-west-2b"]
replication_group_id = "tf-rep-group-1"
description = "example description"
node_type = "cache.m4.large"
num_cache_clusters = 2
parameter_group_name = "default.redis3.2"
port = 6379
}Description
This policy identifies ElastiCache Redis clusters that have Multi-AZ Automatic Failover feature set to disabled. It is recommended to enable the Multi-AZ Automatic Failover feature for your Redis Cache cluster, which will improve primary node reachability by providing read replica in case of network connectivity loss or loss of availability in the primary's availability zone for read/write operations.\nNote: Redis cluster Multi-AZ with automatic failover does not support T1 and T2 cache node types and is only available if the cluster has at least one read replica. 🎉 Fixed by commit adaa9ed - fix regex
|
/test all |
goruha
approved these changes
Mar 27, 2023
|
/test all |
brian-weis-msr
pushed a commit
to Measurabl/terraform-aws-elasticache-redis
that referenced
this pull request
Apr 2, 2024
* Baseline fixes * Groundwork new workflows * fix regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lint/format before workflows rollout