Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: import existing replication groups #217

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

y3ti
Copy link
Contributor

@y3ti y3ti commented Dec 19, 2023

what

Ignore security_group_names for aws_elasticache_replication_group resource.

why

There is a bug in the terraform aws provider: hashicorp/terraform-provider-aws#32835
When importing an aws_elasticache_replication_group resource the attribute security_group_names is imported as null.

The security_group_names attribute is not used by this module.

references

@y3ti y3ti requested review from a team as code owners December 19, 2023 13:26
@milldr
Copy link
Member

milldr commented Dec 21, 2023

/terratest

Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks for the contribution

@milldr milldr merged commit b7c841a into cloudposse:main Dec 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants