Allow config endpoint as reader endpoint output #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required when running in cluster mode as there is no reader endpoint
kevcube
approved these changes
Sep 12, 2024
kevcube
added
enhancement
|
/terratest |
1 similar comment
|
/terratest |
|
/terratest |
|
These changes were released in v1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This avoids a situation where the reader endpoint tries to use
coalesce(null, null, null)when in cluster mode and instead uses the configuration endpoint.why
When using cluster mode there is no reader endpoint so the output tries to use
coalesce(null, null, null)which results in a plan error. As outlined in the AWS docs the config endpoint should be used instead when in cluster mode.references
Closes #236