Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Valkey engine #249

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

adamantike
Copy link
Contributor

what

This change allows setting the engine variable, to allow using Valkey as the cache engine.

No breaking changes are expected, as the default value for the engine variable is set to redis. Also, the minimum AWS provider version is not changed as using Redis does not require using a newer provider.

references

This change allows setting the `engine` variable, to allow using Valkey
as the cache engine.

No breaking changes are expected, as the default value for the `engine`
variable is set to `redis`. Also, the minimum AWS provider version is
not changed as using Redis does not require using a newer provider.
@adamantike adamantike requested review from a team as code owners October 25, 2024 20:17
@mergify mergify bot added the triage Needs triage label Oct 25, 2024
@mergify mergify bot removed the triage Needs triage label Oct 26, 2024
@nitrocode nitrocode enabled auto-merge (squash) October 26, 2024 12:40
@nitrocode
Copy link
Member

/terratest

@nitrocode nitrocode merged commit f2fa535 into cloudposse:main Oct 26, 2024
41 checks passed
@adamantike adamantike deleted the feat/add-valkey-support branch October 26, 2024 13:00
Copy link
Contributor

These changes were released in v1.7.0.

@Nuru
Copy link
Contributor

Nuru commented Oct 29, 2024

@nitrocode In the future, before approving a PR like this, please ensure that enumerators like these (engine is either redis or valkey) have their legal values enumerated along with explanations of what they mean. Short explanation (e.g. "type of cache") in the variable description; long explanation with link to even more information in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants