Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of Redis in cluster mode #65

Merged
merged 3 commits into from
May 15, 2020
Merged

Fix creation of Redis in cluster mode #65

merged 3 commits into from
May 15, 2020

Conversation

samsullivan
Copy link
Contributor

what

  • fix creation on cluster_mode_enabled
  • don't send number_cache_clusters or availability_zones for cluster mode

why

references

@samsullivan samsullivan mentioned this pull request Mar 30, 2020
Closed
@samsullivan samsullivan mentioned this pull request Apr 16, 2020
Merged
@dilsilva
Copy link

This PR merge will be very appreciated :B

@samsullivan
Copy link
Contributor Author

Awesome, thanks!

@aknysh
Copy link
Member

aknysh commented May 14, 2020

/codefresh run test

1 similar comment
@aknysh
Copy link
Member

aknysh commented May 15, 2020

/codefresh run test

@aknysh
Copy link
Member

aknysh commented May 15, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented May 15, 2020

/codefresh run test

aknysh
aknysh approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @samsullivan

@aknysh aknysh merged commit 2025cb6 into cloudposse:master May 15, 2020
@samsullivan samsullivan deleted the fix-cluster-mode branch May 15, 2020 01:30
@samsullivan
Copy link
Contributor Author

No problem, appreciate it getting merged.

brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@samsullivan @actions-bot @brian-weis-msr
Fix creation of Redis in cluster mode (cloudposse#65)
758c319 
* No number_cache_clusters if cluster_mode_enabled

See cloudposse#64

* No explicit AZs in cluster mode

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error evaluating cluster_mode when var.cluster_mode_enabled = true
4 participants
@samsullivan @dilsilva @aknysh @actions-bot