Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUTOMATED] Update Version Pinning for Terraform to support 0.13 #74

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[AUTOMATED] Update Version Pinning for Terraform to support 0.13 #74

merged 1 commit into from
Aug 13, 2020

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Aug 6, 2020

What

  1. Update Version Pinning for Terraform to support 0.13

Why

  1. This is a relatively minor update that the CloudPosse module already likely supports.
  2. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.

@Gowiem
[AUTOMATED] Update Version Pinning for Terraform to support 0.13
4755648 
## What

1. Update Version Pinning for Terraform to support 0.13

## Why

1. This is a relatively minor update that the CloudPosse module already likely supports.
1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.
@Gowiem Gowiem requested a review from a team as a code owner August 6, 2020 00:07
@Gowiem Gowiem requested review from htplbc and joe-niland and removed request for a team August 6, 2020 00:07
@Gowiem Gowiem self-assigned this Aug 6, 2020
@Gowiem
Copy link
Member Author

Gowiem commented Aug 6, 2020

/test all

samsullivan
samsullivan approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@samsullivan samsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not expecting this to be merged w/only my input; but, LGTM and would love to see this released. Aligns with other Cloudposse PRs for TF 0.13.0 and tests pass 👍

@nitrocode nitrocode merged commit 01e71ca into master Aug 13, 2020
@nitrocode nitrocode deleted the version-pin branch August 13, 2020 15:24
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@Gowiem @brian-weis-msr
[AUTOMATED] Update Version Pinning for Terraform to support 0.13 (clo…
21b3abe 
…udposse#74)

## What

1. Update Version Pinning for Terraform to support 0.13

## Why

1. This is a relatively minor update that the CloudPosse module already likely supports.
1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@samsullivan samsullivan samsullivan approved these changes

@htplbc htplbc Awaiting requested review from htplbc

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees

@Gowiem Gowiem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gowiem @samsullivan @nitrocode