feat: support `multi_az_with_standby_enabled` for opensearch #196

lukehsiao · 2024-10-10T23:35:36Z

feat: support multi_az_with_standby_enabled for opensearch

Note that this bumps the minimum hashicorp/aws provider version to
5.15.0, where this parameter was introduced [1].

The README diff was generated with make init and make readme, and
introduces some minor unrelated changes.

Closes: #195

what

This PR simply exposes a new variable (multi_az_with_standby_enabled) for OpenSearch clusters.

why

This is the recommended setting by AWS, so it makes sense to be able to do this via terraform.

references

Closes: #195

Gowiem

One request to confirm before we move this forward 👍

Gowiem · 2024-10-12T05:50:50Z

opensearch_domain.tf

+    dedicated_master_enabled      = var.dedicated_master_enabled
+    dedicated_master_count        = var.dedicated_master_count
+    dedicated_master_type         = var.dedicated_master_type
+    multi_az_with_standby_enabled = var.multi_az_with_standby_enabled


What version of the AWS provider was multi_az_with_standby_enabled added in? Does our current pin of the AWS provider in versions.tf require that version or above? Please look into this, update if needed, and then rerun the README generation with make init && make readme. Thanks!

Thanks for the callout! It does need a minimum bump, the variable was introduced in https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5150-august-31-2023. I've updated that value and run README generation. Note that that make readme fixes some things I missed when I did it manually, but also introduces some minor, seemingly unrelated changes (e.g., extra /).

Gowiem · 2024-10-12T23:43:57Z

/terratest

lukehsiao · 2024-10-14T16:33:36Z

I see some test failures, but looking at the logs, they don't look directly related to my change. If I'm responsible for getting these to passing, could anyone provide some guidance?

Gowiem · 2025-02-06T16:11:44Z

/terratest

Gowiem

mergify · 2025-02-06T16:17:25Z

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

Gowiem · 2025-02-06T16:18:04Z

@lukehsiao the tests for this child module need some action from the @cloudposse team as there is an issue with the tests failing to find some R53 records in their AWS account. I'll bring this up internally to the contributors group and we'll work to get someone on it shortly. Thanks for the patience!

goruha · 2025-03-20T17:27:47Z

@lukehsiao could you pls fix the code style formatting?
it seem there are some nonprintable chars (spaces or tabs) that need to be removed

diff --git a/variables.tf b/variables.tf
index 7b0d0b[5](https://github.com/cloudposse/terraform-aws-elasticsearch/actions/runs/13168882144/job/36798395645?pr=196#step:6:6)..63f2d31 100644
--- a/variables.tf
+++ b/variables.tf
@@ -143,[7](https://github.com/cloudposse/terraform-aws-elasticsearch/actions/runs/13168882144/job/36798395645?pr=196#step:6:8) +143,7 @@ variable "availability_zone_count" {
 
 variable "multi_az_with_standby_enabled" {
   type        = bool
-  default     = false  
+  default     = false
   description = "Enable domain with standby for OpenSearch cluster"
 }

lukehsiao · 2025-03-20T18:07:22Z

@lukehsiao could you pls fix the code style formatting? it seem there are some nonprintable chars (spaces or tabs) that need to be removed

diff --git a/variables.tf b/variables.tf
index 7b0d0b[5](https://github.com/cloudposse/terraform-aws-elasticsearch/actions/runs/13168882144/job/36798395645?pr=196#step:6:6)..63f2d31 100644
--- a/variables.tf
+++ b/variables.tf
@@ -143,[7](https://github.com/cloudposse/terraform-aws-elasticsearch/actions/runs/13168882144/job/36798395645?pr=196#step:6:8) +143,7 @@ variable "availability_zone_count" {
 
 variable "multi_az_with_standby_enabled" {
   type        = bool
-  default     = false  
+  default     = false
   description = "Enable domain with standby for OpenSearch cluster"
 }

Apologies. Making the change now.

update: this is done.

Note that this bumps the minimum `hashicorp/aws` provider version to 5.15.0, where this parameter was introduced [[1]]. The README diff was generated with `make init` and `make readme`, and introduces some minor unrelated changes. [1]: https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5150-august-31-2023 Closes: cloudposse#195

Gowiem · 2025-03-24T21:26:59Z

/terratest

Gowiem · 2025-03-24T21:28:33Z

versions.tf

@@ -4,7 +4,7 @@ terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
-      version = ">= 3.35.0"
+      version = ">= 5.15.0"


If we're bumping to this version, this is considered a major version bump as it requires users to bump to a new provider version. Just calling that out explicitly here since this is now a larger change than just a new var + argument usage.

Gowiem · 2025-03-24T21:29:48Z

@goruha looks like we're still failing with the following, can you investigate?

TestExamplesComplete 2025-03-24T21:28:55Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: no matching Route 53 Hosted Zone found
│ 
│   with module.elasticsearch.module.domain_hostname.data.aws_route53_zone.default[0],
│   on .terraform/modules/elasticsearch.domain_hostname/main.tf line 5, in data "aws_route53_zone" "default":
│    5: data "aws_route53_zone" "default" {
│ 
╵
╷
│ Error: no matching Route 53 Hosted Zone found
│ 
│   with module.elasticsearch.module.kibana_hostname.data.aws_route53_zone.default[0],
│   on .terraform/modules/elasticsearch.kibana_hostname/main.tf line 5, in data "aws_route53_zone" "default":
│    5: data "aws_route53_zone" "default" {
│ 
╵}

Thank you!

lukehsiao requested review from a team as code owners October 10, 2024 23:35

lukehsiao requested review from Gowiem and jamengual October 10, 2024 23:35

mergify bot added the triage label Oct 10, 2024

Gowiem requested changes Oct 12, 2024

View reviewed changes

lukehsiao force-pushed the main branch 3 times, most recently from 0232f59 to a0c05dd Compare October 12, 2024 16:29

lukehsiao requested a review from Gowiem October 12, 2024 16:29

Gowiem added enhancement minor labels Oct 12, 2024

lukehsiao force-pushed the main branch from a0c05dd to 8a2ae29 Compare February 6, 2025 00:02

Gowiem enabled auto-merge (squash) February 6, 2025 16:12

Gowiem previously approved these changes Feb 6, 2025

View reviewed changes

mergify bot removed the triage label Feb 6, 2025

Gowiem added the needs-cloudposse label Feb 6, 2025

goruha self-assigned this Mar 20, 2025

auto-merge was automatically disabled March 20, 2025 18:09
Head branch was pushed to by a user without write access

lukehsiao dismissed Gowiem’s stale review via 12cdbe7 March 20, 2025 18:09

lukehsiao force-pushed the main branch from 8a2ae29 to 12cdbe7 Compare March 20, 2025 18:09

Gowiem reviewed Mar 24, 2025

View reviewed changes

Gowiem added major and removed minor labels Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support `multi_az_with_standby_enabled` for opensearch #196

feat: support `multi_az_with_standby_enabled` for opensearch #196

lukehsiao commented Oct 10, 2024 •

edited

Loading

Uh oh!

Gowiem left a comment

Uh oh!

Gowiem Oct 12, 2024

Uh oh!

lukehsiao Oct 12, 2024

Uh oh!

Gowiem commented Oct 12, 2024

Uh oh!

lukehsiao commented Oct 14, 2024

Uh oh!

Gowiem commented Feb 6, 2025

Uh oh!

Gowiem left a comment

Uh oh!

mergify bot commented Feb 6, 2025

Cloud Posse Engineering Team Review Required

Uh oh!

Gowiem commented Feb 6, 2025

Uh oh!

goruha commented Mar 20, 2025

Uh oh!

lukehsiao commented Mar 20, 2025 •

edited

Loading

Uh oh!

Gowiem commented Mar 24, 2025

Uh oh!

Gowiem Mar 24, 2025

Uh oh!

Gowiem commented Mar 24, 2025

Uh oh!

feat: support multi_az_with_standby_enabled for opensearch #196

Are you sure you want to change the base?

feat: support multi_az_with_standby_enabled for opensearch #196

Conversation

lukehsiao commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what

why

references

Uh oh!

Gowiem left a comment

Choose a reason for hiding this comment

Uh oh!

Gowiem Oct 12, 2024

Choose a reason for hiding this comment

Uh oh!

lukehsiao Oct 12, 2024

Choose a reason for hiding this comment

Uh oh!

Gowiem commented Oct 12, 2024

Uh oh!

lukehsiao commented Oct 14, 2024

Uh oh!

Gowiem commented Feb 6, 2025

Uh oh!

Gowiem left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 6, 2025

Cloud Posse Engineering Team Review Required

Uh oh!

Gowiem commented Feb 6, 2025

Uh oh!

goruha commented Mar 20, 2025

Uh oh!

lukehsiao commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Gowiem commented Mar 24, 2025

Uh oh!

Gowiem Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Gowiem commented Mar 24, 2025

Uh oh!

feat: support `multi_az_with_standby_enabled` for opensearch #196

feat: support `multi_az_with_standby_enabled` for opensearch #196

lukehsiao commented Oct 10, 2024 •

edited

Loading

lukehsiao commented Mar 20, 2025 •

edited

Loading