Allow use of 3 availability zones

[fliphess]

Allow use of 3 availability zones after hashicorp/terraform-provider-aws#9398

[aknysh]

thanks @fliphess

Looks good, but please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

thanks

[aknysh]

also please take a look at this terraform apply error (from the tests):

TestExamplesComplete 2019-07-22T13:38:33Z command.go:121: Error: Unsupported argument                                                                                                     
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121:                                                                                                                                 
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121:   on ../../main.tf line 129, in resource "aws_elasticsearch_domain" "default":                                                  
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121:  129:       zone_awareness_enabled  = var.zone_awareness_enabled                                                                
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121:                                                                                                                                 
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121: An argument named "zone_awareness_enabled" is not expected here.                                                                
TestExamplesComplete 2019-07-22T13:38:33Z command.go:121:                                                                                                                                 
TestExamplesComplete 2019-07-22T13:38:33Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}                                                                

[fliphess]

Ah thanks for pointing out where to look :)

I'll look into it, sorry for not looking after the tests and adjust correctly, I was at work and was hoping for a quick win :)

[fliphess]

@aknysh The tests look a lot better now, but still testing with 2 azs. What would you suggest for changing the tests?

I personally would prefer to test the module using 3 azs as well with 2, but that would I'm not in command of your infra and AWS billing so I'm not sure if I should just change the code example that is used for testing :)

[aknysh]

thanks @fliphess
feel free to add another AZ here https://github.com/cloudposse/terraform-aws-elasticsearch/blob/master/examples/complete/fixtures.us-west-1.tfvars#L9

[aknysh]

/codefresh run test

[fliphess]

Did the last testrun succeed? I wasn't able to view the output......

[aknysh]

/codefresh run test

[aknysh]

@fliphess
we need to look into this in more details.
your changes are correct, but our tests use us-west-1 region that has only 2 AZs per account (and the AZs are different for diff accounts), so currently we can't test with 3 AZs in us-west-1

[osterman]

/codefresh run test

[aknysh]

/codefresh run test

[aknysh]

/codefresh run test

[fliphess]

Hey @aknysh, Let me know what you have in mind, for now, I reverted the last commit that adds the third AZ so the test will succeed.

I think how to test in multiple availability zones is mostly a Cloudposse decision and not a a community effort as it's your billing and your AWS account :)

(Thanks btw for the high quality terraform modules, highly appreciated)

[fliphess]

Maybe merge this PR and start a new issue to come up with a solution for the missing third availability zone? Keep me posted :)

[aknysh]

/codefresh run test

[aknysh]

/codefresh run test

[aknysh]

thanks @fliphess
we'll update the tests to use 3 AZs in another PR