Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: allow enabling CloudWatch logs without SNS/SQS notifications #16

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Feat: allow enabling CloudWatch logs without SNS/SQS notifications #16

merged 4 commits into from
Nov 26, 2021

Conversation

max-lobur
Copy link
Contributor

what

  • CloudWatch logs is a standalone flag now

why

  • CloudWatch logs is a self-sufficient log sink and can be collected without using SNS/SQS destinations
  • SNS on top of the CloudWatch is now a separate flag

@max-lobur max-lobur requested review from a team as code owners November 22, 2021 15:14
@max-lobur
Copy link
Contributor Author

/test all

osterman
osterman previously approved these changes Nov 26, 2021
View reviewed changes
@korenyoni korenyoni added the enhancement New feature or request label Nov 26, 2021
@korenyoni korenyoni changed the title Allow enabling CloudWatch logs without the SNS/SQS notifications Feat: allow enabling CloudWatch logs without SNS/SQS notifications Nov 26, 2021
@max-lobur
Copy link
Contributor Author

/test all

@mergify mergify bot dismissed osterman’s stale review November 26, 2021 19:07

This Pull Request has been updated, so we're dismissing all reviews.

@max-lobur max-lobur merged commit b8ee1f8 into cloudposse:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@osterman osterman osterman left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-lobur @osterman @korenyoni @cloudpossebot