Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add feature flag for dynamically setting ServiceAccount Role ARN annotation #10

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Oct 5, 2021

what

  • Add feature flag for dynamically setting ServiceAccount Role ARN annotation, which is set to true by default.
  • Misc: change wording for var.service_account_namespace to avoid confusion between var.namespace and var.kubernetes_namespace.

why

  • Assuming the Helm Chart follows the standard convention of rendering ServiceAccount annotations in serviceAccount.annotations, this allows the ServiceAccount created by the Helm Chart to assume the IAM Role in question via the EKS OIDC IdP, without the consumer of this module having to set this annotation via var.values or var.set, which would involve manually rendering the IAM Role ARN beforehand (since not doing so would introduce a cycle in the graph).

references

  • N/A

@korenyoni korenyoni added the enhancement New feature or request label Oct 5, 2021
@korenyoni korenyoni requested review from a team as code owners October 5, 2021 16:18
max-lobur
max-lobur previously approved these changes Oct 5, 2021
@korenyoni korenyoni requested review from bradj, nitrocode and a team October 5, 2021 16:19
main.tf Show resolved Hide resolved
@korenyoni korenyoni merged commit d47de4a into master Oct 5, 2021
@korenyoni korenyoni deleted the feat/dynamic-sa-annotation branch October 5, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants