Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: allow var.name to be set to empty #11

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Feat: allow var.name to be set to empty #11

merged 5 commits into from
Oct 6, 2021

Conversation

korenyoni
Copy link
Member

what

  • Allow var.name to be set to empty by coalescing var.name with var.chart for the helm_release resource.
  • Update README.

why

  • var.name is optional in eks-iam-role. Omitting it results in shorter names for IAM Roles created for ServiceAccounts, if var.service_account_name is supplied. However, the name attribute for the helm_release resource is not optional, so it should be coalesced with var.chart.

references

@korenyoni korenyoni added the patch A minor, backward compatible change label Oct 6, 2021
@korenyoni korenyoni requested review from a team as code owners October 6, 2021 14:38
aknysh
aknysh reviewed Oct 6, 2021
View reviewed changes
README.md Show resolved Hide resolved
aknysh
aknysh reviewed Oct 6, 2021
View reviewed changes
README.yaml Show resolved Hide resolved
aknysh
aknysh reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korenyoni LGTM, one comment

@korenyoni korenyoni requested a review from aknysh October 6, 2021 16:39
@korenyoni korenyoni merged commit 37e8543 into master Oct 6, 2021
@korenyoni korenyoni deleted the feat/allow-var-name-empty branch October 6, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korenyoni @aknysh @nitrocode @cloudpossebot