-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make service account key path as variable #12
Conversation
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new variable should also be referenced by var.service_account_role_arn_annotation_enabled
.
description = <<-EOT
Whether or not to dynamically insert an `eks.amazonaws.com/role-arn` annotation into `${var.service_account_set_key_path}.annotations`
(by default, `serviceAccount.annotations`), with the value being the ARN of the IAM role created when `var.iam_role_enabled`.
Assuming the Helm Chart follows the standard convention of rendering ServiceAccount annotations in `serviceAccount.annotations`
(or a similar convention, which can be achieved by overriding `var.service_account_set_key_path` as needed),
this allows the ServiceAccount created by the Helm Chart to assume the IAM Role in question via the EKS OIDC IdP, without
the consumer of this module having to set this annotation via `var.values` or `var.set`, which would involve manually
rendering the IAM Role ARN beforehand.
Ignored if `var.iam_role_enabled` is `false`.
EOT
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
This Pull Request has been updated, so we're dismissing all reviews.
This Pull Request has been updated, so we're dismissing all reviews.
what
why
variables.yaml
structure,for some you use
serviceAccount
key path for annotations but other userbac.serviceAccount
.