Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service account key path as variable #12

Merged
merged 9 commits into from
Oct 12, 2021

Conversation

goruha
Copy link
Member

@goruha goruha commented Oct 12, 2021

what

  • Made service account key path as variable

why

  • Different charts use different variables.yaml structure,
    for some you use serviceAccount key path for annotations but other use rbac.serviceAccount.

@goruha goruha requested review from a team as code owners October 12, 2021 13:53
@goruha
Copy link
Member Author

goruha commented Oct 12, 2021

/test all

variables.tf Outdated Show resolved Hide resolved
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

goruha and others added 2 commits October 12, 2021 20:02
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
aknysh
aknysh previously approved these changes Oct 12, 2021
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new variable should also be referenced by var.service_account_role_arn_annotation_enabled.

  description = <<-EOT
  Whether or not to dynamically insert an `eks.amazonaws.com/role-arn` annotation into `${var.service_account_set_key_path}.annotations`
  (by default, `serviceAccount.annotations`), with the value being the ARN of the IAM role created when `var.iam_role_enabled`.
  
  Assuming the Helm Chart follows the standard convention of rendering ServiceAccount annotations in `serviceAccount.annotations`
  (or a similar convention, which can be achieved by overriding `var.service_account_set_key_path` as needed),
  this allows the ServiceAccount created by the Helm Chart to assume the IAM Role in question via the EKS OIDC IdP, without
  the consumer of this module having to set this annotation via `var.values` or `var.set`, which would involve manually
  rendering the IAM Role ARN beforehand.
  
  Ignored if `var.iam_role_enabled` is `false`.
  EOT

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
@mergify mergify bot dismissed korenyoni’s stale review October 12, 2021 14:19

This Pull Request has been updated, so we're dismissing all reviews.

variables.tf Outdated Show resolved Hide resolved
korenyoni
korenyoni previously approved these changes Oct 12, 2021
@mergify mergify bot dismissed korenyoni’s stale review October 12, 2021 14:27

This Pull Request has been updated, so we're dismissing all reviews.

@korenyoni korenyoni changed the title Made service account key path as variable Make service account key path as variable Oct 12, 2021
@goruha goruha merged commit 5baf322 into master Oct 12, 2021
@goruha goruha deleted the customize-service-account-path branch October 12, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants