Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, add testing #40

Merged
merged 3 commits into from
May 21, 2023
Merged

Update dependencies, add testing #40

merged 3 commits into from
May 21, 2023

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented May 20, 2023

what

  • Update dependencies
  • Add basic testing

why

  • Bring in new features and bug fixes. In particular, check aud field of OIDC assertion for EKS IRSA "assume role".
  • Because of the nature of this module, it did not have the testing Cloud Posse wants all modules to undergo. Although the testing added in this module is minimal, it does validate that the module is able to deploy a Helm chart without obvious errors, which is better than nothing.

references

notes

Using aws-node-termination-handler as the test deployment was not my idea, it was mostly set up by the pre-existing code. A better test would allow for functional testing that everything installed is working correctly, but that would take significantly more time to implement.

@Nuru Nuru requested review from a team as code owners May 20, 2023 21:17
@Nuru Nuru requested review from Gowiem and joe-niland May 20, 2023 21:17
@Nuru Nuru added the patch A minor, backward compatible change label May 20, 2023
examples/complete/main.tf Show resolved Hide resolved
examples/complete/main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

examples/complete/main.tf Show resolved Hide resolved
@Nuru Nuru requested a review from osterman May 20, 2023 21:43
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented May 20, 2023

/terratest

@Nuru Nuru enabled auto-merge (squash) May 20, 2023 22:01
@Nuru Nuru merged commit 36c0395 into main May 21, 2023
@Nuru Nuru deleted the oidc-audience branch May 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests
5 participants