Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require mfa auth for deletion of mfa device #14

Merged
merged 1 commit into from
Dec 26, 2018
Merged

require mfa auth for deletion of mfa device #14

merged 1 commit into from
Dec 26, 2018

Conversation

russelltsherman
Copy link
Contributor

@russelltsherman russelltsherman commented Dec 26, 2018 •
edited by osterman
Loading

what

  • A user must be authenticated with an mfa device to be allowed to delete their own mfa device

why

  • I think this allows an attacker to create a new MFA device without MFA authenticationwhat

references

@osterman osterman requested a review from aknysh December 26, 2018 17:54
osterman
osterman approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russelltsherman looks great! Thanks for the Chrismas contribution gift @russelltsherman =)

@osterman osterman merged commit 6738f2f into cloudposse:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Tightening Restrictions
2 participants
@russelltsherman @osterman