Added inputs, deprecated source_json

[nitrocode]

what

• Added inputs, deprecated source_json
• Use latest tests

why

• Use non-deprecated input

references

• Closes source_json is deprecated. Use the attribute "source_policy_documents" instead. #12
• This works for aws 3.x too https://registry.terraform.io/providers/hashicorp/aws/3.75.2/docs/data-sources/iam_policy_document#override_policy_documents
• After this PR, we want to update https://github.com/cloudposse/terraform-aws-helm-release

[nitrocode]

/test all

[nitrocode]

/test all

[nitrocode]

/test all

[Gowiem]

@nitrocode looks like a great upgrade 👍 One nitpick on the description of the updated var, but otherwise I think it looks ready to go.

[Gowiem]

@nitrocode I imagine this should be a major version rev, correct? Do we have automation in place to make that happen or do you need to do this as a non-release and then release manually?

[nitrocode]

/test all

[nitrocode]

@nitrocode I imagine this should be a major version rev, correct? Do we have automation in place to make that happen or do you need to do this as a non-release and then release manually?

Hmm I don't know. The patch version is for backwards compatibility. The minor version is for adding new functionality in a backwards compatible manner. And major version is for breaking changes. I suppose this is a breaking change unless I add a variables-deprecated.tf file and if source_json input is used, it uses a local to combine it with the source_policy_documents. I'd prefer to not release a major version for now since this module is still kind of "incubating" since it's new.

Perhaps I should go with the deprecated route to avoid breaking changes then?

[Gowiem]

@nitrocode Eh, if we don't want to major rev because we're still considering it incubating then that seems like a good enough reason to me to just rev minor and skip the deprecated workaround. Don't want to create a big hoop to jump through just because we're trying to move towards reving major versions... we haven't done it everywhere yet AFAICT so it seems like adding more work when it's likely overkill.

Thanks for jumping on my nitpick 👍

[Gowiem]

@nitrocode leaving up to you to merge 👍