feat: define iam_policy_statements object syntax

[gberenice]

what

• This updates iam_policy_statements variable definition to take Terraform object with optional attributes rather than type = any. Provider version is bumped since optional, as a non-experimental feature, was introduced in 1.3.

why

• Provide more control over the expected structure of the input data for IAM policy statements.

references

• Slack thread + PR #692.

[Gowiem]

/terratest

[Gowiem]

/terratest

[Nuru]

Change "Map of" to "Object describing"

[gberenice]

Change "Map of" to "Object describing"

@Nuru from what I can see - a map is expected here, so I fixed the variable definition.

[Nuru]

• Add version here and in main.tf.
• Move statement components to list of objects.
• Inputs that are not going to be expanded into blocks by dynamic should default to null.
• In main.tf, replace lookups like

lookup(statement.value, "sid", statement.key)

With direct references

statement.value.sid

Suggested change

	type = object({
	sid = optional(string, "")
	effect = optional(string, "")
	actions = optional(list(string), [])
	not_actions = optional(list(string), [])
	resources = optional(list(string), [])
	not_resources = optional(list(string), [])
	type = object({
	version = optional(string, null)
	statement = list(object({
	sid = optional(string, null)
	effect = optional(string, null)
	actions = optional(list(string), null)
	not_actions = optional(list(string), null)
	resources = optional(list(string), null)
	not_resources = optional(list(string), null)
	})), [])

[gberenice]

@Nuru thanks a lot for your review!

• Version arguments should be set for data source aws_iam_policy_document, so I added it as a separate variable.
• I updated statements to the map of objects - that's what is expected in the example.
• Inputs were updated.
• Lookups were replaced👍

Please let me know your thoughts.

[Nuru]

@gberenice I forgot we want this to be backward compatible and that means the input is a map. I will take it from here. Thank you very much for your contributions.

[gberenice]

@Nuru sounds good, thank you!

[Nuru]

/terratest

Changes made

[aknysh]

please see comments

[Nuru]

/terratest

[aknysh]

please update the description for the iam_source_json_url variable in the example as well

description = <<-EOT
    URL of the IAM policy (in JSON format) to download and use as `source_json` argument.
    This is useful when using a 3rd party service that provides their own policy.
    This can be used with or instead of `var.iam_policy`.
    EOT

[aknysh]

please see comment

[Nuru]

/terratest