Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deprecated input to type "any" #30

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Revert deprecated input to type "any" #30

merged 1 commit into from
Aug 30, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 30, 2023

Breaking Change

The iam_policy input introduced in v1.0.0 has been changed from type object to type list(object). This allows multiple policy objects to be provided, but more importantly, allows no input or allows the iam_policy input to be used along with the deprecated iam_policy_statements input.

Reversion of Breaking Change

In v1.0.0, the iam_policy_statements input was deprecated, but it was also converted from type any to type map(object), which was how it was documented. However, it was, in practice, allowed to be a list or a map, and many users were supplying lists. This made it an unintentional breaking change for those users.

In this release, iam_policy_statements (while still deprecated) is reverted to type any and accepts both a map and a list.

what

  • Revert iam_policy_statements back to type = any
  • Convert iam_policy input to list
  • Update documentation

why

  • Preserve backward compatibility with pre v1.0 module
  • Enable all inputs to be used in any combination
  • Reflect changes to usage, remove leftovers from initial template

references

@Nuru Nuru added the major Breaking changes (or first stable release) label Aug 30, 2023
@Nuru Nuru requested review from a team as code owners August 30, 2023 10:43
@Nuru
Copy link
Contributor Author

Nuru commented Aug 30, 2023

/terratest

@Nuru Nuru merged commit 621bd76 into main Aug 30, 2023
@Nuru Nuru deleted the deprecated-type-any branch August 30, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants