Update Security Group module #45
Conversation
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
you'll need to deprecate the sg inputs from before the pre release versions |
|
/test all |
|
/test all |
There was a problem hiding this comment.
Use security-group-variables.tf version 2, not security_group_inputs.tf version 1.
I may have other requests for changes on top of that.
mergify
bot
dismissed
Nuru’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
There is a missing migration doc. Do we need one here ? There are some modules that have one and others that do not, cc: @Nuru |
|
/test all |
I've added that doc |
|
@nitrocode @milldr Anything holding this one up? I've got an old client who it is blocking so I'd love to see it ship for them and make an old colleague of mine happy! |
Yes, @Nuru is making several additional upgrades to the upstream modules before this PR can be merged. @Nuru do you have a status update for this PR? |
|
/test all |
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| var.security_groups | ||
| )) | ||
| ) | ||
| security_groups = local.broker_security_groups |
There was a problem hiding this comment.
Ensure Amazon MQ Broker logging is enabled
Resource: aws_mq_broker.default | ID: BC_AWS_LOGGING_10
Description
Amazon MQ is a broker service built on Apache ActiveMQ. As a message broker, MQ allows applications to communicate using various programming languages, operating systems and formal messaging protocols.Amazon MQ is integrated with CloudTrail and provides a record of the Amazon MQ calls made by a user, role, or AWS service. It supports logging both the request parameters and the responses for APIs as events in CloudTrail. Logging MQ ensures developers can trace all requests and responses, and ensure they are only used for their predefined message brokering settings.
We recommend you enable Amazon MQ Broker Logging.
Benchmarks
- HIPAA 164.312(B) Audit controls
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_LOGGING_10 Added /main.tf aws_mq_broker.default
| var.security_groups | ||
| )) | ||
| ) | ||
| security_groups = local.broker_security_groups |
There was a problem hiding this comment.
Ensure Amazon MQ Broker logging is enabled
Resource: module.mq_broker.aws_mq_broker.default | ID: BC_AWS_LOGGING_10
Description
Amazon MQ is a broker service built on Apache ActiveMQ. As a message broker, MQ allows applications to communicate using various programming languages, operating systems and formal messaging protocols.Amazon MQ is integrated with CloudTrail and provides a record of the Amazon MQ calls made by a user, role, or AWS service. It supports logging both the request parameters and the responses for APIs as events in CloudTrail. Logging MQ ensures developers can trace all requests and responses, and ensure they are only used for their predefined message brokering settings.
We recommend you enable Amazon MQ Broker Logging.
Benchmarks
- HIPAA 164.312(B) Audit controls
|
/test all |
what
why
notes
This PR introduces breaking changes and will be released as version 2.0. Migration document is here.
references
hashicorp/templateunnecessary dependency #37