update to context

[syphernl]

what

• Update to context.tf

why

• Standardization and interoperability

[syphernl]

I would really appreciate it if this PR could be tagged with hacktoberfest-accepted so it counts towards my Hacktoberfest PR's (since the repo isn't tagged with hacktoberfest)

[RothAndrew]

Referring review to leadership, @osterman or other please take a look. I don't know enough about context.tf to know if this was done the way we want it to be done.

For the record, I effing hate hacktoberfest. It has been directly responsible for an absolute tidal wave of crap that has inundated many open source repos with low quality PRs.

Not saying this is one of those, just voicing a general opinion 😄

[Gowiem]

/test all

[osterman]

Thanks @syphernl (Frank!) We'll have @aknysh take a look

[aknysh]

please see comments

[RothAndrew]

Removing my "request changes" as @aknysh is now reviewing

@aknysh is now reviewing

[RothAndrew]

/test all

[aknysh]

/test all

[aknysh]

thanks @syphernl
Please add enabled = true to fixtures.us-east-2.tfvars similar to this https://github.com/cloudposse/terraform-aws-elasticsearch/blob/master/examples/complete/fixtures.us-east-2.tfvars#L1

[aknysh]

/test all

[aknysh]

@syphernl
please fix these errors:

estExamplesComplete 2020-10-21T14:37:38Z command.go:121:   on ../../public.tf line 22, in resource "aws_subnet" "public":
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:   22:     "Name"      = "${module.public_label.id}${var.delimiter}${element(var.subnet_names, count.index)}"
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:     |----------------
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:     | var.delimiter is null
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: 
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: The expression result is null. Cannot include a null value in a string
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: template.
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: 
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: 
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: Error: Invalid template interpolation value
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121: 
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:   on ../../public.tf line 22, in resource "aws_subnet" "public":
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:   22:     "Name"      = "${module.public_label.id}${var.delimiter}${element(var.subnet_names, count.index)}"
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:     |----------------
TestExamplesComplete 2020-10-21T14:37:38Z command.go:121:     | var.delimiter is null

All variables that are present now in the context.tf file, need to be replaced with module.this.xxxx.
For example, var.delimiter needs to be replaced with module.this.delimeter in all files and examples.
The same for all other variables.

What you can do to speed up the testing and find all errors, is:

1. cd examples/complete
2. terraform init
3. terraform plan

It will show you if there are any errors before we deploy the example on AWS

Thank you for all your work on PRs.

[syphernl]

@aknysh The delimiter has been fixed and the sample is passing terraform plan -var-file=fixtures.us-east-2.tfvars

[aknysh]

/test all

[aknysh]

thanks @syphernl
It looks good and works now