Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firewall rule group #5

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Update firewall rule group #5

merged 2 commits into from
Jan 31, 2023

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jan 31, 2023 •
edited
Loading

what

  • Update firewall rule group
  • Simplify some dynamic blocks

why

  • stateful_rule.rule_option, custom_action and stateless_rule are sets of dynamic blocks, not single blocks

@aknysh aknysh added the patch A minor, backward compatible change label Jan 31, 2023
@aknysh aknysh self-assigned this Jan 31, 2023
@aknysh aknysh requested review from a team as code owners January 31, 2023 18:20
@aknysh aknysh requested review from Gowiem and dotCipher January 31, 2023 18:20
@aknysh
Copy link
Member Author

aknysh commented Jan 31, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented Jan 31, 2023

/test all

@aknysh aknysh merged commit 87f8e64 into main Jan 31, 2023
@aknysh aknysh deleted the update-rule-groups branch January 31, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@dudymas dudymas Awaiting requested review from dudymas

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@nitrocode nitrocode Awaiting requested review from nitrocode

@osterman osterman Awaiting requested review from osterman

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @max-lobur