Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation #1

Merged
merged 17 commits into from
Jan 6, 2019
Merged

Initial implementation #1

merged 17 commits into from
Jan 6, 2019

Conversation

osterman
Copy link
Member

@osterman osterman commented Jan 6, 2019

what

  • Create a module specific for RDS replicas

why

  • Provide RDS replicas for reporting purposes
  • Cannot set a null value for allocated_storage in terraform-aws-rds

references

@osterman osterman mentioned this pull request Jan 6, 2019
Closed
@osterman osterman requested a review from aknysh January 6, 2019 03:22
aknysh
aknysh reviewed Jan 6, 2019
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
@aknysh @osterman
Update LICENSE
61cb789 
Co-Authored-By: osterman <erik@cloudposse.com>
aknysh
aknysh reviewed Jan 6, 2019
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 6, 2019
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
aknysh and others added 2 commits January 5, 2019 20:40
@aknysh @osterman
Update README.yaml
78a14a7 
Co-Authored-By: osterman <erik@cloudposse.com>
@aknysh @osterman
Update README.yaml
1a6daad 
Co-Authored-By: osterman <erik@cloudposse.com>
aknysh
aknysh reviewed Jan 6, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 6, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@osterman osterman requested a review from aknysh January 6, 2019 05:08
@osterman osterman merged commit e428509 into master Jan 6, 2019
@osterman osterman deleted the init branch January 6, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @aknysh