Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.14 upgrade #32

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Terraform 0.14 upgrade #32

merged 2 commits into from
Feb 4, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 5, 2021

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

  • Support Terraform 0.14

@maximmi maximmi requested review from a team as code owners January 5, 2021 16:20
@maximmi maximmi requested review from Makeshift and brcnblc and removed request for a team January 5, 2021 16:20
@maximmi maximmi self-assigned this Jan 5, 2021
@maximmi
Copy link
Contributor Author

maximmi commented Jan 6, 2021

/test all

Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change

@@ -34,7 +34,7 @@ jobs:
fi

- name: Create Pull Request
if: steps.update.outputs.create_pull_request == 'true'
if: {{ steps.update.outputs.create_pull_request == 'true' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use expressions in an if conditional, you may omit the expression syntax (${{ }}) because GitHub automatically evaluates the if conditional as an expression. For more information about if conditionals, see Workflow syntax for GitHub Actions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/test all

@mergify mergify bot dismissed mcalhoun’s stale review January 7, 2021 14:24

This Pull Request has been updated, so we're dismissing all reviews.

@codeaprendiz
Copy link

Hii amazing folks,
When are we merging this PR ? :)

@osterman osterman merged commit 576d117 into master Feb 4, 2021
@osterman osterman deleted the terraform-0.14-upgrade branch February 4, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants