Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix count calculation #9

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Fix count calculation #9

merged 3 commits into from
Nov 16, 2017

Conversation

SweetOps
Copy link
Contributor

@SweetOps SweetOps commented Nov 15, 2017 •
edited by const-bon
Loading

What

  • Fix count calculation

Why

@SweetOps SweetOps self-assigned this Nov 15, 2017
@SweetOps
Copy link
Contributor Author

screenshot 2017-11-15 16 25 05

@const-bon
Copy link

@SweetOps will it work if we set only one of parent_zone_id or parent_zone_name?

@SweetOps
Copy link
Contributor Author

@comeanother, both use cases has been tested

@const-bon const-bon mentioned this pull request Nov 16, 2017
Closed
@const-bon const-bon changed the title Fix count of data sources when using interpolations Fix count calculation Nov 16, 2017
@const-bon const-bon added the bug 🐛 An issue with the system label Nov 16, 2017
const-bon
const-bon approved these changes Nov 16, 2017
View reviewed changes
Copy link

@const-bon const-bon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. See #8

@const-bon const-bon merged commit 9254363 into master Nov 16, 2017
@const-bon const-bon deleted the rework branch November 16, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-bon const-bon const-bon approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees

@SweetOps SweetOps

Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SweetOps @const-bon