Replication role is created as '-replication'

[amila-ku]

Describe the Bug

S3 role used for file replication is created as '-replication'

Expected Behavior

S3 role used for file replication is should be 'modulename-replication' or 'bucketname-replication'

Steps to Reproduce

Create two s3 buckets
Create s3 replication from one bucket to the other.
Check the role name that gets created.

Observed with Terraform 1.8.0, haven't checked with other versions yet.

Screenshots

I applied the changes with fix in #250. This is the output when i try to apply without the fix.

  # module.s3_bucket_storage.aws_iam_policy.replication[0] must be replaced
-/+ resource "aws_iam_policy" "replication" {
      ~ arn              = "arn:aws:iam::xxxxxxxxxx:policy/my-files-production-replication" -> (known after apply)
      ~ attachment_count = 1 -> (known after apply)
      ~ id               = "arn:aws:iam::xxxxxxxxxx:policy/my-files-production-replication" -> (known after apply)
      ~ name             = "my-files-production-replication" -> "-replication" # forces replacement
      + name_prefix      = (known after apply)
      ~ policy_id        = "xxxxxxxxx" -> (known after apply)
      - tags             = {} -> null
      ~ tags_all         = {} -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # module.s3_bucket_storage.aws_iam_role.replication[0] must be replaced
-/+ resource "aws_iam_role" "replication" {
      ~ arn                   = "arn:aws:iam::xxxxxx:role/my-files-production-replication" -> (known after apply)
      ~ create_date           = "2024-08-06T15:01:28Z" -> (known after apply)
      ~ id                    = "my-files-production-replication" -> (known after apply)
      ~ managed_policy_arns   = [
          - "arn:aws:iam::xxxxxxxxxxx:policy/KMSReplicationAccess",
          - "arn:aws:iam::xxxxxxxxxxx:policy/my-files-production-replication",
        ] -> (known after apply)
      ~ name                  = "my-files-production-replication" -> "-replication" # forces replacement
      + name_prefix           = (known after apply)
      - tags                  = {} -> null
      ~ tags_all              = {} -> (known after apply)
      ~ unique_id             = "ABCDD" -> (known after apply)
        # (6 unchanged attributes hidden)

Environment

No response

Additional Context

No response