Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes broken replication iam role name #250

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fixes broken replication iam role name #250

wants to merge 3 commits into from

Conversation

amila-ku
Copy link

@amila-ku amila-ku commented Sep 18, 2024 •
edited
Loading

what

  • Fixes replication IAM role name that gets created as '-replication'

why

  • Replication IAM role name gets created as '-replication'. This made the replication role unsusable.
  • Used Terraform version: 1.8.0

references

@amila-ku amila-ku requested review from a team as code owners September 18, 2024 09:41
@mergify mergify bot added the triage Needs triage label Sep 18, 2024
@amila-ku amila-ku mentioned this pull request Sep 18, 2024
Open
@amila-ku amila-ku changed the title fix: fixes broken replication name fix: fixes broken replication iam role name Sep 18, 2024
nitrocode
nitrocode reviewed Sep 18, 2024
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Sep 18, 2024
View reviewed changes
replication.tf
Copy link
Member

@nitrocode nitrocode Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the inputs youre using for the bucket? Are you passing in the name, environment, stage, etc or only the bucket_name ?

nitrocode
nitrocode reviewed Sep 18, 2024
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
amila-ku and others added 2 commits September 28, 2024 02:52
@amila-ku @nitrocode
fix: use local value
93b4aac 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@amila-ku @nitrocode
fix: use bucket name from local
920aef6 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replication role is created as '-replication'
2 participants
@amila-ku @nitrocode