Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringNotLike must match entire string #14

Merged
merged 2 commits into from
Apr 29, 2021
Merged

StringNotLike must match entire string #14

merged 2 commits into from
Apr 29, 2021

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Apr 29, 2021

what

  • Fix broken ec2-policies

why

  • StringLike and StringNotLike allow wildcards, but still must match the full string. If the value is r5n.large and the test is StringLike r5n the test will fail, because it is not a full string match.
  • t3 and r5n are not Instance Types, they are Instance Families. A test on InstanceTypes needs to include the size designator, e.g. r5n.large or m5.metal

@Nuru Nuru added the bugfix Change that restores intended behavior label Apr 29, 2021
@Nuru Nuru requested review from a team as code owners April 29, 2021 02:53
@Nuru Nuru requested a review from a team as a code owner April 29, 2021 02:54
- c6gn.*
- d3.*
- d3en.*
- g4.*
- i3.metal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why i3.metal is left, but i3en.metal is replaced with i3en.* ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we replace all .metal with .* ?

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list reflects the AWS documentation. Virtualized i3en is listed, but i3 is not.

The following instances are built on the Nitro System:

  • Virtualized: A1, C5, C5a, C5ad, C5d, C5n, C6g, C6gd, C6gn, D3, D3en, G4, I3en, Inf1, M5, M5a, M5ad, M5d, M5dn, M5n, M5zn, M6g, M6gd, p3dn.24xlarge, P4, R5, R5a, R5ad, R5b, R5d, R5dn, R5n, R6g, R6gd, T3, T3a, T4g, X2gd, and z1d

  • Bare metal: a1.metal, c5.metal, c5d.metal, c5n.metal, c6g.metal, c6gd.metal, i3.metal, i3en.metal, m5.metal, m5d.metal, m5dn.metal, m5n.metal, m5zn.metal, m6g.metal, m6gd.metal, mac1.metal, r5.metal, r5b.metal, r5d.metal, r5dn.metal, r5n.metal, r6g.metal, r6gd.metal, u-6tb1.metal, u-9tb1.metal, u-12tb1.metal, u-18tb1.metal, u-24tb1.metal, x2gd.metal, and z1d.metal

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a small nitpick

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Apr 29, 2021

/test all

@Nuru Nuru requested a review from aknysh April 29, 2021 16:58
@Nuru Nuru merged commit e9fd1de into master Apr 29, 2021
@mergify mergify bot deleted the fix-stringnotlike branch April 29, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants