Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deny disabling cloutrail scp #19

Merged
merged 3 commits into from
Mar 21, 2022
Merged

add deny disabling cloutrail scp #19

merged 3 commits into from
Mar 21, 2022

Conversation

sgtoj
Copy link
Sponsor Contributor

@sgtoj sgtoj commented Mar 21, 2022

what

  • add new scp to prevent cloudtrail from being disabled

why

  • prevent cloudtrail from being disabled by bad actors

references

  • n/a

@sgtoj sgtoj requested review from a team as code owners March 21, 2022 20:09
@sgtoj sgtoj requested review from jhosteny and woz5999 March 21, 2022 20:09
@sgtoj sgtoj requested review from a team as code owners March 21, 2022 20:09
@aknysh
Copy link
Member

aknysh commented Mar 21, 2022

/test all

@sgtoj
Copy link
Sponsor Contributor Author

sgtoj commented Mar 21, 2022

/test all

1 similar comment
@aknysh
Copy link
Member

aknysh commented Mar 21, 2022

/test all

aknysh
aknysh approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sgtoj

@aknysh aknysh merged commit 345aff9 into cloudposse:master Mar 21, 2022
@sgtoj sgtoj deleted the cloudtrail-scp branch March 23, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgtoj @aknysh @cloudpossebot