Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 'id' output to properly output the disambiguated ID of the provisioned AWS Transfer Server #21

Closed

Conversation

girdot
Copy link

@girdot girdot commented Jun 1, 2022

what

the 'id' output was an empty string, this causes it to be the disambiguated id of the provisioned AWS Transfer Server

references

@girdot girdot requested review from a team as code owners June 1, 2022 02:17
@girdot girdot requested review from a team as code owners June 1, 2022 02:17
@girdot girdot requested review from florian0410 and Benbentwo June 1, 2022 02:17
outputs.tf Outdated Show resolved Hide resolved
@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 1, 2022
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

@girdot please update the

assert.Equal(t, id, id2, "Expected `id` to be stable")

Here is the error

s-042a17d9b4f84575b.server.transfer.us-east-2.amazonaws.com
=== CONT  TestExamplesComplete
    examples_complete_test.go:53: 
        	Error Trace:	examples_complete_test.go:53
        	Error:      	Not equal: 
        	            	expected: "eg-ue2-test-example-43825"
        	            	actual  : "s-042a17d9b4f84575b"

Please also use the pr template as that will be used for the release notes

@nitrocode nitrocode self-requested a review June 2, 2022 05:44
@mergify
Copy link

mergify bot commented Jun 11, 2022

This pull request is now in conflict. Could you fix it @girdot? 🙏

@hans-d hans-d added the stale This PR has gone stale label Mar 8, 2024
@hans-d hans-d closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change stale This PR has gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Transfer ID
4 participants