Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cidr_block with ipv4_cidr_block in README #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MajinBuuOnSecurity
Copy link

Copy link
Member

@joe-niland joe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MajinBuuOnSecurity

Thanks for your PR.
To make this change, please update README.yaml then run:

make init
make readme

@joe-niland joe-niland added the no-release Do not create a new release (wait for additional code changes) label Nov 10, 2023
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 4, 2024

From the top of the READme file involved

  ** DO NOT EDIT THIS FILE
  **
  ** This file was automatically generated by the `cloudposse/build-harness`.
  ** 1) Make all changes to `README.yaml`
  ** 2) Run `make init` (you only need to do this once)
  ** 3) Run`make readme` to rebuild this file.

@MajinBuuOnSecurity Can you apply the fix to the right file and execute the rebuild?

Copy link

mergify bot commented Mar 9, 2024

Thanks @MajinBuuOnSecurity for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the stale This PR has gone stale label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants