Add support for network address usage metrics #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
nitrocode
reviewed
Oct 14, 2023
main.tf
Outdated
| enable_dns_hostnames = local.dns_hostnames_enabled | ||
| enable_dns_support = local.dns_support_enabled | ||
| assign_generated_ipv6_cidr_block = local.assign_generated_ipv6_cidr_block | ||
| enable_network_address_usage_metrics = var.enable_network_address_usage_metrics |
There was a problem hiding this comment.
Please use the cp convention where the enabled is past tense and suffixed instead of prefixed to keep arguments consistent
Suggested change
| enable_network_address_usage_metrics = var.enable_network_address_usage_metrics | |
| enable_network_address_usage_metrics = var.network_address_usage_metrics_enabled |
There was a problem hiding this comment.
Thanks for the feedback it's done!
joe-niland
approved these changes
Nov 10, 2023
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR adds support for Network Address Usage Metrics on the VPC.
AWS documentation : https://docs.aws.amazon.com/vpc/latest/userguide/network-address-usage.html
Terraform documentation : https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc#enable_network_address_usage_metrics
why
Network Address Usage metrics can help monitor the growth of a VPC and would be useful for any user.
Enable this after creating a VPC does not trigger recreation of the VPC.
references
closes #115