Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-Add_enable_machine_learning_bot_control #91

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Feature-Add_enable_machine_learning_bot_control #91

merged 1 commit into from
Jul 23, 2024

Conversation

jgalais
Copy link
Contributor

@jgalais jgalais commented Jul 23, 2024 •
edited
Loading

Hello,

what

  • I added "enable_machine_learning" argument inside "aws_managed_rules_bot_control_rule_set" config

why

  • I added this argument to avoid idempotency problem if you use "COMMON" inspection level.

regards,
Jgalais

@jgalais jgalais requested review from a team as code owners July 23, 2024 14:33
@mergify mergify bot added the triage Needs triage label Jul 23, 2024
@jgalais jgalais force-pushed the Feature-Add_enable_machine_learning_bot_control branch from 059c73e to f34df55 Compare July 23, 2024 14:37
@aknysh
Copy link
Member

aknysh commented Jul 23, 2024

/terratest

aknysh
aknysh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jgalais

@aknysh aknysh added minor New features that do not break anything and removed triage Needs triage labels Jul 23, 2024
@aknysh aknysh merged commit 9b735fc into cloudposse:main Jul 23, 2024
21 checks passed
@github-actions GitHub Actions
Copy link

These changes were released in v1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgalais @aknysh