Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor slo module. Update monitor-based SLOs to be able to create corresponding monitors #69

Merged
merged 12 commits into from
Aug 15, 2022

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Aug 13, 2022

what

  • Refactor slo module
  • Update monitor-based SLOs to be able to create corresponding monitors
  • Add example of monitor-based SLO
  • Update README

why

  • Separate metric-based SLOs and monitor-based SLOs into different files for readability
  • When creating monitor-based SLOs, allow specifying and creating the corresponding monitors and assigning them to the SLOs (in YAML config for each SLO)
  # For each monitor-based SLO, either `monitor_ids` or `monitors` should be provided
  # `monitor_ids` is a list of externally created monitors to use for the monitor-based SLO
  # If `monitors` map is provided, the monitors will be created by the module and assigned to the SLO

references

@aknysh aknysh added the major Breaking changes (or first stable release) label Aug 13, 2022
@aknysh aknysh self-assigned this Aug 13, 2022
@aknysh aknysh requested review from a team as code owners August 13, 2022 04:18
@aknysh aknysh requested review from Gowiem and korenyoni August 13, 2022 04:18
@aknysh
Copy link
Member Author

aknysh commented Aug 13, 2022

/test all

@aknysh
Copy link
Member Author

aknysh commented Aug 13, 2022

/test all

Copy link

@danjbh danjbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aknysh aknysh merged commit ccc10c5 into master Aug 15, 2022
@aknysh aknysh deleted the update-monitor-based-slo branch August 15, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants